PR 1233: redesign the VNC console

The View panel's Reset to defaults sets every setting back to its default, including View only, which now lives in the toolbar. So someone watching in View only who resets the zoom starts sending their mouse and keyboard to the VM. In my re-check, a click and a key after the reset went out as 3 pointer and 2 key events (dropped by the test).

Fix: reset only the panel's own settings (scaling, zoom, quality, compression) and keep View only. Pass B has a scratch unit test that fails on the head commit and passes with that change.

The redesign makes Automatic (fit to the window) the default, but main writes its own default, Manual at 100%, to the same localStorage key the first time the console opens, without the user choosing anything. The new default only reaches browsers that never opened the console. Everyone else gets the 720x400 screen in a big black area after the upgrade.

Fix: the simplest is a new storage key, so main's auto-saved defaults don't count as a choice. Someone who really picked Manual on main picks it once more.

flex: 1 on every slider is meant for the zoom row, but in the column sections it sets the height, so those two inputs collapse to their 4px track. A click on the visible thumb, 6px off the line, doesn't move it; only a click on the line does. Zoom is fine (20px).

Fix: apply the flex: 1 only to the zoom row's slider.

RcDropdown collects its items when the menu opens. Turning a modifier on swaps the keys below it (Print Screen and the F-keys become N, T, W, Y, or Del), and the new items aren't in its list, so ArrowDown stops at Alt. With a mouse it works. Main's old menu had no keyboard access at all, so it isn't a regression, but the new keyboard path breaks half way.

Fix: keep the same items while the menu is open, for example render every key and disable the ones that don't go with what is held. Pass B reasoned this from RcDropdown's code; not tried yet.

While the save runs, the delete buttons and Add shortcut are disabled. The one just pressed has focus, and a focused button that gets disabled drops focus to the page, so the next Tab starts again from the top of the dialog (WCAG 2.4.3). On main, a keyboard delete keeps focus on a close button.

Fix: don't disable the buttons during the save; add and remove can return early while saving is set.

The dialog reports a failed save only with a growl, and the console page uses the blank layout, which has no growls. With the save failing, a delete leaves the row and a new shortcut doesn't appear, with no message. On main the Save button turned into "Error".

Fix: show the error in the dialog itself, for example a Banner above the list.

The recorder waits for another key after a modifier, so pressing only the Windows key records nothing. Main's recorder saved "Meta" on its own, which is the clean way to open the guest's Start menu, since the physical key goes to the host.

Fix: when a modifier is released with nothing else pressed, record it on its own.

Ken's Figma draws Send Ctrl+Alt+Del red, so the PR overrides RcButton's primary with the error colors. On PR 1225 you asked for normal usage instead of a red Delete, and the shell's RcModal story uses a plain primary for its own Delete confirmation. One of the two has to give: Ken's red or normal usage.

The 3.42:1 contrast both passes measured in dark is not counted: it's the theme's own .bg-error pair, the same on every Delete in Rancher.

"The console disconnects while the VM restarts and reconnects when it is back." comes from Ken's frame. Reading KubeVirt, with rebootPolicy unset (true for every VM on both backends) the guest restarts inside the same QEMU, so the console should stay connected and show the restart. A real soft reboot is off limits on the shared VMs, so this is from the code only.

The override of _refreshCursor reads noVNC's private _cursorImage. rfb.showDotCursor = true is public and covers the same case, but draws a small dot instead of the arrow, which is a look decision. The private override can break on a noVNC upgrade. The two-pointer case on a desktop VM is still untested (no graphical VM on either backend), and it would apply to both.

The card says "This virtual machine is starting" while the pill next to it says "Not running".

The dialog stays mounted, so a combination and name you recorded but didn't add come back the next time it opens, which reads like they might have been saved. Main rebuilt the dialog each time.

The menu keeps its own key lists while the wrapper still maps the same keys to keysyms, with labels nothing reads now. A key added to one and not the other throws in sendKeys.

• l10n/en-us.yaml:1158: status.failed and status.reconnecting are no longer read.
• components/novnc/NovncViewOptions.vue:222: .view-options__mode button { flex: 1 } never reaches ButtonGroup's buttons (scoped CSS).
• components/novnc/NovncConsoleWrapper.vue:686: the console only mounts while running, so its vmRunning prop is always true.
• components/novnc/shortcuts.js:41: the { name, keys } branch reads a shape nothing writes.

The wrapper is at 55% line coverage: finding a stopped VM by uid, the starting state, the grace period, the keys sendKeys passes on and the reset have no tests. A reset test would have caught finding 1.

The open docs PR for issue 12015 explains the current toolbar with screenshots, and QA's manual test still says to click Shortcut Keys, then Ctrl, Alt, Del. Both need an update when this lands. Not something to change in the PR.

• Red text in dark, 2.38:1 (Reconnect) and 3.42:1 (confirm button). Both passes measured them. They are the theme's own --error / --error-text: the shell's .text-error and .bg-error give the same numbers in this build, so it isn't this PR's.
• Full screen bar at 3.8:1 at rest. Cody's probe flagged it; the rendered pixels give 5.32:1 (it ignored the bar's 0.7 opacity over the black screen), and Pass B measured it passing too.
• Shared components: the Checkbox's 14px box, ButtonGroup's hover at 4.41:1, RcDropdownTrigger without aria-controls. Same anywhere in Rancher.
• Pass B's optional N7 and N9 (Options API instead of Composition API; "Del" and "Space" not translated): left out.